Merged
Conversation
EagleoutIce
approved these changes
Jan 30, 2026
There was a problem hiding this comment.
Pull request overview
This PR hardens diagram generation against race conditions where the internal Flowr session is not yet ready, and avoids opening empty diagram panels when generation fails.
Changes:
- In
FlowrInternalSession.startWorkWithProgressBar, added a retry loop that waits for the internal parser/session to become available (with bounded backoff) before creating an analyzer, and shows a clear error if the session never becomes ready. - Ensured
workingstate is managed correctly when the session never initializes by explicitly resetting it before returning on failure. - In
DiagramUpdateCoordinator.createDiagramPanel, prevented diagram webview creation when the underlying mermaid generation returns an empty string, treating that as a failed generation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/flowr/internal-session.ts | Adds bounded retry and user-facing error handling when the internal Flowr analyzer session is not yet ready before performing diagram work. |
| src/flowr/diagrams/diagram.ts | Skips creating a diagram webview when mermaid generation fails and returns an empty string, avoiding empty/invalid panels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.